AWARE [SYSTEMS] Imaging expertise for the Delphi developer
AWare Systems, Imaging expertise for the Delphi developer, Home TIFF and LibTiff Mailing List Archive

LibTiff Mailing List

TIFF and LibTiff Mailing List Archive
August 2008

Previous Thread
Next Thread

Previous by Thread
Next by Thread

Previous by Date
Next by Date

Contact

The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems



Valid HTML 4.01!



Thread

2008.08.11 17:57 "windows 64 bit build", by Mikhail Kruk
2008.08.11 19:29 "Re: windows 64 bit build", by Bob Friesenhahn
2008.08.11 19:35 "Re: windows 64 bit build", by Mikhail Kruk
2008.08.11 20:03 "Re: windows 64 bit build", by Edward Lam
2008.08.11 20:55 "Re: windows 64 bit build", by Bob Friesenhahn
2008.08.11 20:51 "Re: windows 64 bit build", by Bob Friesenhahn
2008.08.12 00:36 "Re: windows 64 bit build", by Edward Lam
2008.08.12 02:44 "Re: windows 64 bit build", by Bob Friesenhahn
2008.08.12 03:53 "Re: windows 64 bit build", by Edward Lam
2008.08.12 04:04 "Re: windows 64 bit build", by Mikhail Kruk
2008.08.12 12:54 "Re: windows 64 bit build", by Edward Lam
2008.08.12 04:47 "Re: windows 64 bit build", by Bob Friesenhahn
2008.08.12 13:04 "Re: windows 64 bit build", by Edward Lam
2008.08.13 04:23 "tif_win32.c patch proposal (was: windows 64 bit build)", by Edward Lam
2008.08.13 05:32 "Re: tif_win32.c patch proposal (was: windows 64 bit build)", by Bob Friesenhahn
2008.09.04 14:12 "Re: tif_win32.c patch proposal", by Edward Lam
2008.08.12 00:41 "Re: windows 64 bit build", by Edward Lam

2008.08.11 20:51 "Re: windows 64 bit build", by Bob Friesenhahn

On Mon, 11 Aug 2008, Mikhail Kruk wrote:

> OK... what would be a good way of fixing it?  Doesn't look like
> TIFFFdOpen interface should be changed; I'm not sure why is it used to
> pass Windows HANDLEs, sounds confusing (as Windows has normal int file
> descriptors as well).  Should we add new functions TIFFHndlOpen or
> something like that?  Win32 only?

In the Windows build, I see that thandle_t is a Windows HANDLE type. 
TIFFFdOpen accepts 'int ifd' and then casts it into the thandle_t for 
use in TIFFClientOpen.  It also caches the 'int' sized value as 
tif->tif_fd:

struct tiff {
         char*                tif_name;         /* name of open file */
         int                  tif_fd;           /* open file descriptor */

Unfortunately, struct tiff is part of the public interface so changing 
it impacts the ABI.  A potential solution is to change the type used 
to pass and store file descriptors so that under Windows, it is always 
large enough to store a void*.

Bob
======================================
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/