LibTiff Mailing List
TIFF and LibTiff Mailing List Archive
August 2008
Previous Thread
Next Thread
Previous by Thread
Next by Thread
Previous by Date
Next by Date
Contact
The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems
Thread
2008.08.13 05:32 "Re: tif_win32.c patch proposal (was: windows 64 bit build)", by Bob Friesenhahn
On Wed, 13 Aug 2008, Edward Lam wrote: >> If you can submit a tested patch, I will be happy to commit it. > > Ok, here's a patch attached for discussion. The approach I previously > mentioned ran into a slight snag. Once you've created an fd for a HANDLE, the > C runtime library (CRT) takes ownership of it. Thus, when you call > _close(fd), it closes the associated HANDLE as well. Plus, in > _tiffCloseProc(), there was no way (that I found) to query the CRT to return > the associated fd given the HANDLE. So in the end, I did something more > drastic, albeit cleaner. It seems that this approach is drastic enough that we should wait for some feedback from potentially impacted users before moving ahead with it. Being more from the Unix mind-set than the Windows mind-set, I like your approach better than the approach which is currently used. Bob ====================================== Bob Friesenhahn bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer, http://www.GraphicsMagick.org/