LibTiff Mailing List

TIFF and LibTiff Mailing List Archive
November 2004

Previous Thread
Next Thread

Previous by Thread
Next by Thread

Previous by Date
Next by Date

The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems

2004.11.05 17:40 "bug in YCbCr support, tiff 3.6.1", by Hans Petter Selasky

BUG: some tables were initialized with wrong value; tiff 3.5.5 initialized the 
table right;
BUG: missing check for division by zero

see attached patch

please CC me, hence I'm not subscribed to this list

Yours
-HPS

*** libtiff/tif_color.c.ref	Fri Nov  5 18:01:44 2004
--- libtiff/tif_color.c	Fri Nov  5 18:26:46 2004
***************
*** 170,176 ****
  #define	SHIFT			16
  #define	FIX(x)			((int32)((x) * (1L<<SHIFT) + 0.5))
  #define	ONE_HALF		((int32)(1<<(SHIFT-1)))
! #define	Code2V(c, RB, RW, CR)
((((c)-(int32)(RB))*(float)(CR))/(float)((RW)-(RB)))
  #define	CLAMP(f,min,max)	((f)<(min)?(min):(f)>(max)?(max):(f))
  
  void
--- 170,176 ----
  #define	SHIFT			16
  #define	FIX(x)			((int32)((x) * (1L<<SHIFT) + 0.5))
  #define	ONE_HALF		((int32)(1<<(SHIFT-1)))
! #define	Code2V(c, RB, RW, CR)
((((c)-(int32)(RB))*(float)(CR))/(float)(((RW)-(RB)) ? ((RW)-(RB)) : 1))
  #define	CLAMP(f,min,max)	((f)<(min)?(min):(f)>(max)?(max):(f))
  
  void
***************
*** 243,252 ****
         * constructing tables indexed by the raw pixel data.
         */
        for (i = 0, x = -128; i < 256; i++, x++) {
! 	    int32 Cr = (int32)Code2V(x, refBlackWhite[4] - 128.0F,
! 			    refBlackWhite[5] - 128.0F, 127);
! 	    int32 Cb = (int32)Code2V(x, refBlackWhite[2] - 128.0F,
! 			    refBlackWhite[3] - 128.0F, 127);
  
  	    ycbcr->Cr_r_tab[i] = (int32)((D1*Cr + ONE_HALF)>>SHIFT);
  	    ycbcr->Cb_b_tab[i] = (int32)((D3*Cb + ONE_HALF)>>SHIFT);
--- 243,252 ----
         * constructing tables indexed by the raw pixel data.
         */
        for (i = 0, x = -128; i < 256; i++, x++) {
! 	    int32 Cr = ((int32)Code2V(x, refBlackWhite[4] - 128.0F,
! 			    refBlackWhite[5] - 128.0F, 255)) - 128;
! 	    int32 Cb = ((int32)Code2V(x, refBlackWhite[2] - 128.0F,
! 			    refBlackWhite[3] - 128.0F, 255)) - 128;
  
  	    ycbcr->Cr_r_tab[i] = (int32)((D1*Cr + ONE_HALF)>>SHIFT);
  	    ycbcr->Cb_b_tab[i] = (int32)((D3*Cb + ONE_HALF)>>SHIFT);