2004.09.02 00:12 "Re: [Tiff] Tiff2Pdf bug", by Ross A. Finlayson

Seems to me that in t2p_read_tiff_init(...), second check for t2p->tiff_pages==NULL, near the beginning of the function, should actually be checking for t2p->tiff_tiles==NULL.

Also, it might not be an error if _TIFFmemset checks for it, but in t2p_init(), top few lines, you might want to move _TIFFmemset(t2p,...) to after the check for t2p==NULL.

Hi Joris,

Thank you for your code review. I have this and some other issues that are being fixed in the tiff2pdf.c file, as I get them fixed I will send the patch to Andrey.

Hey I got the "yet another TIFF tag viewer" property sheet shell extension for Windows working, I need to add the rest of the help and warning/error functions and then I hope you will try it, hopefully this week. I'm even unable to crash the Explorer with it recently.

I found a bug in libtiff, when a floating point is returned for a SRATIONAL value for printing the value, the two int32's should be treated as an int32 for the numerator and uint32 for the denominator.

Hey about the palette and some notion of compressing the palette, I thought one method that was in use was to compress the ColorMap with LZW, and then when the library gets the ColorMap, if its number of elements doesn't match the SamplesPerPixel/PhotometricInterpretation/ExtraSamples/Indexed indicated correct value for the count of elements of the ColorMap, then it is uncompressed transparently for the ColorMap access.

Regards,

Ross F.