LibTiff Mailing List

TIFF and LibTiff Mailing List Archive
February 2010

Previous Thread
Next Thread

Previous by Thread
Next by Thread

Previous by Date
Next by Date

The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems

Thread

2010.02.26 08:11 "Patch for tif_unix.c", by Eric Doenges

2010.02.26 14:30 "Re: Patch for tif_unix.c", by Edward Lam

2010.02.26 17:05 "Re: Patch for tif_unix.c", by Bob Friesenhahn

2010.02.26 17:43 "Re: Patch for tif_unix.c", by Edward Lam

2010.02.26 18:06 "Re: Patch for tif_unix.c", by Bob Friesenhahn

2010.02.26 19:24 "Re: Patch for tif_unix.c", by Edward Lam

2010.03.02 08:14 "Re: Patch for tif_unix.c", by Eric Doenges

2010.03.02 14:11 "Re: Patch for tif_unix.c", by Toby Thain

2010.03.02 14:53 "Re: Patch for tif_unix.c", by Scott Ribe

2010.03.02 15:42 "Re: Patch for tif_unix.c", by Toby Thain

2010.03.02 15:52 "Re: Patch for tif_unix.c", by Scott Ribe

2010.03.02 16:14 "Re: Patch for tif_unix.c", by Bob Friesenhahn

2010.03.02 16:51 "Re: Patch for tif_unix.c", by Scott Ribe

2010.03.02 16:55 "Re: Patch for tif_unix.c", by Toby Thain

2010.03.02 14:21 "Re: Patch for tif_unix.c", by Edward Lam

2010.03.02 16:05 "Re: Patch for tif_unix.c", by Eric Doenges

2010.03.02 18:13 "Re: Patch for tif_unix.c", by Edward Lam

2010.02.26 17:43 "Re: Patch for tif_unix.c", by Edward Lam

Bob Friesenhahn wrote:
> It does not seem like your patch deals with the case where the system 
> call returns -1 to indicate an error.  This is important to deal with 

I see that in the patch?

+                if (0 > (bytes = read((int) fd, (char *) buf + total,
+                                      size_io - total)))
+                        return (tmsize_t) -1;

Note that the calling code of the read/write proc functions always check 
if the returned size matches what was requested and issues an error if 
they don't.

Regards,
-Edward