LibTiff Mailing List
TIFF and LibTiff Mailing List Archive
February 2010
Previous Thread
Next Thread
Previous by Thread
Next by Thread
Previous by Date
Next by Date
Contact
The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems
Thread
2010.02.26 18:06 "Re: Patch for tif_unix.c", by Bob Friesenhahn
On Fri, 26 Feb 2010, Edward Lam wrote: > Bob Friesenhahn wrote: >> It does not seem like your patch deals with the case where the system call >> returns -1 to indicate an error. This is important to deal with > > I see that in the patch? > > + if (0 > (bytes = read((int) fd, (char *) buf + total, > + size_io - total))) > + return (tmsize_t) -1; > > Note that the calling code of the read/write proc functions always check if > the returned size matches what was requested and issues an error if they > don't. Hmmm. It seems that you are often right. However, I still see a bug due to the type definition of 'bytes'. Do you see it too? Bob -- Bob Friesenhahn bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer, http://www.GraphicsMagick.org/