- 2010.02.26 14:30 "Re: [Tiff] Patch for tif_unix.c", by Edward Lam
-
2010.02.26 17:05 "Re: [Tiff] Patch for tif_unix.c", by Bob Friesenhahn
- 2010.02.26 17:43 "Re: [Tiff] Patch for tif_unix.c", by Edward Lam
-
2010.03.02 08:14 "Re: [Tiff] Patch for tif_unix.c", by Eric Doenges
- 2010.03.02 14:11 "Re: [Tiff] Patch for tif_unix.c", by Toby Thain
- 2010.03.02 14:21 "Re: [Tiff] Patch for tif_unix.c", by Edward Lam
2010.02.26 18:06 "Re: [Tiff] Patch for tif_unix.c", by Bob Friesenhahn
It does not seem like your patch deals with the case where the system
call returns -1 to indicate an error. This is important to deal with
I see that in the patch?
+ if (0 > (bytes = read((int) fd, (char *) buf + total,
+ size_io - total)))
+ return (tmsize_t) -1;Note that the calling code of the read/write proc functions always check if the returned size matches what was requested and issues an error if they don't.
Hmmm. It seems that you are often right. However, I still see a bug due to the type definition of 'bytes'. Do you see it too?
Bob
--
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/