2008.05.26 14:24 "Re: [Tiff] beta2 release - lfind() problem on Win64", by Edward Lam

Hi,

In trying to compile libtiff 4.0 beta 2 on Win64 with MSVC 8, I've the following warning which I think needs fixing: encountered

tif_dirinfo.c(508): warning C4133: 'function': incompatible types -
'size_t *' to 'unsigned int *' from

The problem is that the call to lfind() on Win64 is redirected to

_lfind() from search.h. For its 3rd argument, it hasn't been updated size_t * (pointer to 64-bits) and still uses unsigned int * to

(pointer to

32-bits). I'm not quite sure what the best solution is at this time. On the one hand, there's a comment that says we should use a binary search. If we did use bsearch(), then it will fix the problem since bsearch() on VC8 has been updated to use size_t (unlike _lfind). On the other hand, I'm not convinced that the array it's trying to search in is sorted. Well, I haven't actually looked but I assume it isn't sorted since it would have been just as easy to call bsearch() instead of lfind().

Any thoughts?

-Edward

Frank Warmerdam wrote:
> Folks,
>
> There are no earth shattering changes, but I have prepared a libtiff 4.0.0
> beta2. Mostly this is to roll in some changes based on an old coverity
> scan of libtiff, and to produce a new tarball I can pass off to coverity
> for analysis.
>
> Coverity produces a static code analysis tool that can identify bugs not
> easily discovered by code inspection, lint style tools, compiler
> warnings or
> runtime analysis with tools like valgrind. They kind provide free support
> for a variety of projects including libtiff. I, umm, failed to followup
> on their previous report some 12 months ago, but talking to their open
> source
> project support fellow at PGCon this week got me off my duff and looking
> into
> stuff. It's pretty sweet, and I'd like to see it become part of the
> libtiff release development and release process over time.
>
> If any of the other libtiff core developers would like access to the
> Coverity
> reports let me know.
>
> Anyways, beta2 is available at:
>

>   http://download.osgeo.org/libtiff/tiff-4.0.0beta2.tar.gz
>   http://download.osgeo.org/libtiff/tiff-4.0.0beta2.zip

>
> Best regards,