2006.07.25 18:27 "Re: [Tiff] Handle not close causing memory leak with libtiff 3.8.2", by Frank Warmerdam

Think I found a very stupid mistake in the file tif_msdos.c of libtiff v3.8.2, line 114:

        return (TIFFFdOpen(fd, name, mode));

Which leave its descriptior "fd" opened if trying to open a file that is not a TIFF. Fix is obvious:

        TIFF * ret = TIFFFdOpen(fd, name, mode);

        if (ret == NULL) close(fd);

        return ret;

Thierry,

I have patched this in CVS. I never imagined anyone was still using tif_msdos.c.

Best regards,
--
---------------------------------------+--------------------------------------

I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam@pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam

and watch the world go round - Rush    | President OSGF, http://osgeo.org