AWARE [SYSTEMS] Imaging expertise for the Delphi developer
AWare Systems, Imaging expertise for the Delphi developer, Home TIFF and LibTiff Mailing List Archive

LibTiff Mailing List

TIFF and LibTiff Mailing List Archive
March 2017

Previous Thread
Next Thread

Previous by Thread
Next by Thread

Previous by Date
Next by Date

Contact

The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems



Valid HTML 4.01!



Thread

2017.03.04 10:59 "started seeing breakage with libtiff", by <jcupitt@gmail.com>
2017.03.04 12:10 "Re: started seeing breakage with libtiff", by Even Rouault
2017.03.04 13:08 "Re: started seeing breakage with libtiff", by <jcupitt@gmail.com>
2017.03.04 18:51 "Re: started seeing breakage with libtiff", by <jcupitt@gmail.com>
2017.03.04 19:19 "Re: started seeing breakage with libtiff", by Bob Friesenhahn
2017.03.04 19:53 "Re: started seeing breakage with libtiff", by Even Rouault
2017.03.05 09:53 "Re: started seeing breakage with libtiff", by <jcupitt@gmail.com>
2017.03.06 15:29 "Re: started seeing breakage with libtiff", by Lee Howard
2017.03.06 15:46 "Re: started seeing breakage with libtiff", by Bob Friesenhahn
2017.03.06 15:59 "Re: started seeing breakage with libtiff", by Toby Thain
2017.03.06 16:26 "Re: started seeing breakage with libtiff", by Lee Howard

2017.03.04 19:53 "Re: started seeing breakage with libtiff", by Even Rouault

On samedi 4 mars 2017 18:51:20 CET jcupitt@gmail.com wrote:
> tar xf tiff_4.0.6-2ubuntu0.1.debian.tar.xz
> tar xf tiff_4.0.6.orig.tar.gz
> cd tiff-4.0.6
> for i in ../debian/patches/*.patch; do patch -p1 < $i; done

Actually to reproduce, you need to apply the patches in a precise order with

for i in `cat ../debian/patches/series`; do \
	patch -p1 <../debian/patches/$i; done

I've then compared the patched libtiff/tif_dirread.c with the official one
from CVS, and I 
understand now what happens in Debian/Ubuntu.

It appears that the following snippet
                  if( dp->tdir_count > 0 && data[dp->tdir_count-1] != '\0' )
                        {
                            TIFFWarningExt(tif->tif_clientdata,module,"ASCII
                    value for tag \"%s\" does not 
end in null byte. Forcing it to be null",fip->field_name);
                            data[dp->tdir_count-1] = '\0';
                        }

that in official libtiff is applied in the TIFF_SETGET_C16_ASCII cases (line
5017 in HEAD) and 
in the TIFF_SETGET_C32_ASCII cases (line 5194 in CVS HEAD) has been wrongly
applied in 
Debian in the TIFF_SETGET_C16_UINT8 case (line 5008) and
TIFF_SETGET_C32_UINT8 case 
(line 5180)...
This explains the warning about the JPEGTables...

Unfortunately "make check" in the Debian patched libtiff still passes, so
they have some 
excuse. Not so surprised since the test suite is rather small.

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com