2013.12.17 12:22 "[Tiff] Checking the TIFFWriteScanline return value", by Robert Pollak

2013.12.17 12:22 "[Tiff] Checking the TIFFWriteScanline return value", by Robert Pollak

Hello list,

four files in libtiff's directory 'test' seem to have the same error:

The snippet
        if (!TIFFWriteScanline(tif, buf, 0, 0) < 0)
should either be
        if (!TIFFWriteScanline(tif, buf, 0, 0))
or (maybe preferably, since the return values are int: -1 or 1)
        if (TIFFWriteScanline(tif, buf, 0, 0) < 0)
.

The current state causes
        warning C4804: '<': unsafe use of type 'bool' in operation
in Visual Studio 2010.

Robert