2004.10.23 03:43 "[Tiff] BUG(configure): --disable-old-jpeg ENABLES "Old JPEG support"", by Norihiko Murase

2004.10.23 03:43 "[Tiff] BUG(configure): --disable-old-jpeg ENABLES "Old JPEG support"", by Norihiko Murase

Hi,

I found the bug in the configure script when I executed it for building tiff-3.7.0.

The '--disable-old-jpeg' configure option does ENABLE "Old JPEG support"! This option '--disable-old-jpeg' should have disabled "Old JPEG support" regardless of the default.

The following patch fixes this problem:

----------(cut here)----------
--- configure.orig      Sat Oct 16 18:05:46 2004
+++ configure   Sat Oct 23 00:07:24 2004
@@ -23671,9 +23671,10 @@

 # Check whether --enable-old-jpeg or --disable-old-jpeg was given.
+HAVE_OJPEG=no
 if test "${enable_old_jpeg+set}" = set; then
   enableval="$enable_old_jpeg"
-  HAVE_OJPEG=yes
-else
-  HAVE_OJPEG=no
+  if test "${enableval}" = "yes" ; then
+    HAVE_OJPEG=yes
+  fi;
 fi;

----------(cut here)----------

The option '--disable-old-jpeg' sets ${enable_old_jpeg} "no", therefore the condition

        test "${enable_old_jpeg+set}" = set

becomes 'true', NOT 'false'.

---
Norihiko Murase <skeleten [AT] shillest.net>