2009.11.01 18:49 "Re: [Tiff] Tiffcrop warnings", by Edward Lam

On Thu, October 29, 2009 23:18, Richard Nolde wrote:

I have a clean compile with tiffcrop updated from CVS Head and patched with new code based on Toby's suggestion. I will test on Friday and advise so we can get tiffcrop into the new release warning free.

I just compiled libtiff CVS HEAD and run into an error compiling tiff_crop.c. On Windows, optind must be explicitly declared as extern. Here is the patch I applied in order for it to compile on Windows:

----------8<------------------------------------------------------------ diff -u -p -r1.14 tiffcrop.c

--- tiffcrop.c  24 Sep 2009 21:57:11 -0000      1.14

+++ tiffcrop.c 1 Nov 2009 18:48:36 -0000
@@ -2084,6 +2084,7 @@ update_output_file (TIFF **tiffout, char
 int
 main(int argc, char* argv[])
   {
+ extern int optind;
   uint16 defconfig = (uint16) -1;
   uint16 deffillorder = 0;
   uint32 deftilewidth = (uint32) 0;
---------->8------------------------------------------------------------

Regards,

-Edward