2020.01.18 13:19 "[Tiff] Warnings while building tools", by Miguel Medalha

2020.01.26 16:37 "Re: [Tiff] Warnings while building tools", by Jeff McKenna

Hi Bob,

Thanks for the changes. (for others, the changes exist at https://gitlab.com/libtiff/libtiff/commit/58b16f47a82323c05ec81f0a821700beb8c2c5a0

)

Feedback:

Please note that those 4 functions (
strtol(),strtoul(),strtol(),strtoul() ) have been available since MSVC
2015 (1900), so that affects your proposed changes. Will you modify

your changes accordingly, or do you want me to create a pull request?

   eg. strtoll() in 2015:

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/strtoll-strtoll-l-wcstoll-wcstoll-l?view=vs-2015

Thanks,

-jeff

--
Jeff McKenna
MapServer Consulting and Training Services
https://gatewaygeomatics.com/

On 2020-01-25 4:24 p.m., Bob Friesenhahn wrote: