AWARE SYSTEMS
TIFF and LibTiff Mail List Archive

Thread

2018.01.15 15:05 "[Tiff] Participation in code review and merging of GitLab merge requests", by Roger Leigh
2018.01.15 15:56 "Re: [Tiff] Participation in code review and merging of GitLab merge requests", by Olivier Paquet

2018.01.15 15:56 "Re: [Tiff] Participation in code review and merging of GitLab merge requests", by Olivier Paquet

2018-01-15 10:05 GMT-05:00 Roger Leigh <rleigh@codelibre.net>:

I've looked over and commented on the open merge requests, but if anyone else was unaware of the open merge requests and wanted to do likewise, this is just a heads up about that. If you alter the notification settings, you'll get them for new ones as they are opened.

Thanks for the heads up. For some reason, I have a hard time with the gitlab UI.

Now might be a good time to discuss how long we would typically want to leave merge requests open before merging them, so that others can have a look if they want to. Given the fairly slow pace of libtiff development, I think about a week would be ok. I'd also be fine with merging sooner if enough people have looked at the code and are ok with it. Or waiting longer than a week too. Which is why I'd like to hear everyone's thoughts on the subject.

Olivier