2020.01.26 23:57 "Re: [Tiff] Warnings while building tools", by Bob Friesenhahn

This happens with the following in nmake.opt:

HAVE_STRTOLL = 1
HAVE_STRTOULL = 1

Meanwhile, I noticed that the warnings disappear if the following lines are disabled in libtiff/tif_config.vc.h:

# if _MSC_VER >= 1920 /* Visual Studio 2019 has strtoll/strtoull */
# define HAVE_STRTOLL 1
# define HAVE_STRTOULL 1
# endif

It seems like the test should be for 1900 (Visual C++ 2015) rather than 1920.

It is unfortunate that the pre-processor logic is produced in two places. It is an issue that tif_config.h is produced in the libtiff directory after the port files have been build. A possible solution is to have nmake enter the libtiff directory for the sole purpose of copying tif_config.h.vc to tif_config.h prior to building the ports directory, and then include tif_config.h in libport.h.

Bob
--
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/

Public Key, http://www.simplesystems.org/users/bfriesen/public-key.txt