2007.08.24 21:08 "[Tiff] A few libtiff4 changes", by Frank Warmerdam

2007.09.12 13:04 "Re: [Tiff] SIZEOF_UNSIGNED_LONG", by Edward Lam

Ooops, sorry, I didn't mean to send that. Here's what I really meant to comment on.

> I wonder if we should either:
> o Require that SIZEOF_UNSIGNED_LONG be explicitly 8 or 4, and if it is not
> defined we #error to stop the build.

What about just erroring if it's not defined? ie.

   #error SIZEOF_UNSIGED_LONG needs to be defined


libtiff now (I'm not clear on how recent this is) checks SIZEOF_UNSIGNED_LONG in tif_fax3.c and has an alternate form of the FILL() macro for 64bit systems. This introduced a bug in GDAL which didn't declare the SIZEOF_UNSIGNED_LONG macro when doing "libtiff internal" builds on 64bit systems.

Er, what happened to the SIZEOF_LONG macro? I'm still using 3.7.0 though.