2012.07.08 16:06 "Re: [Tiff] Challenge to properly eliminate warning", by Edward Lam

On 07/07/2012 10:13 AM, Bob Friesenhahn wrote:

Proposal: at the beginning of TIFFReadDirEntryByte(), add:

Index: tif_dirread.c
===================================================================

--- tif_dirread.c       (révision 24659)
+++ tif_dirread.c       (copie de travail)

@@ -197,6 +197,7 @@
 static enum TIFFReadDirEntryErr TIFFReadDirEntryByte(TIFF* tif, TIFFDirEntry*
direntry, uint8* value)
 {
        enum TIFFReadDirEntryErr err;
+ *value = 0;

That was my first thought (and what I will likely do) but with such carefully articulated code I was worried I might cover up an actual minor error which might be solved.

Are we guaranteed that value != NULL for all calls to TIFFReadDirEntryByte()?

-Edward