2016.12.13 18:52 "Re: [Tiff] one little ill-advised change in v4.0.7 broke functionality for HylaFAX", by Lee Howard

On 12/13/2016 10:06 AM, Even Rouault wrote:

Ideally HylaFAX should not rely on that, or there should be a cleaner way in libtiff to export the tables (a get function) and the structure should be defined in a public header of libtiff.

You'll have no argument from me that HylaFAX shouldn't be doing things differently from the way that it is. All I'm trying to say is that a dependency existed for a long, long time now originating with the author of both software packages.

Looks like in the above Hylafax imports libtiff tables (the U must be undefined, hence imported). OK so it must also have its redefinition of typedef struct TIFFFaxTabEnt in its code, since tif_fax3.h is not installed (or it has a copy of tif_fax3.h)?

It has its own copy of tif_fax3.h (which includes TIFFFaxTabEnt)...

https://sourceforge.net/p/hylafax/HylaFAX+/HEAD/tree/trunk/faxd/tif_fax3.h

Again, I have no doubt whatsoever that this could all be done cleaner/better. I'm just saying that it is what it is.

OK, I'll revert that with a prominent warning so that the next one that touches this code is aware of those tricky aspects that cannot be anticipated from libtiff code itself.

Thanks. If you want to provide a code change for HylaFAX then I'm happy to consider it.

Thanks,

Lee.