2010.06.18 14:16 "Re: [Tiff] libtiff 4.0 compiler warning on x64 in tif_read.c", by Olivier Paquet

On Fri, Jun 18, 2010 at 9:18 AM, Edward Lam <edward@sidefx.com> wrote:

I could go and just do blind type changes from int to tmsize_t until the

I wouldn't do it blindly just yet but it looks like both instances of read_ahead in there should have been tmsize_t.

compiler is satisfied but that's just a losing battle if we keep adding new code that has such warnings. Is there some gcc flag we can add to make it NOT compile such code?

Perhaps so for 64-bit gcc (couldn't find it though) but I don't think anything can be done if the author is working on a 32-bit system where there is nothing to warn about. We just have to deal with the fact that different compilers emit different sets of warnings.

Incidentally, what do we do for Windows? When new code is committed into libtiff, how do we even know that it builds under Windows? We can

We don't unless we try and build it. Nor can we ever be certain that it builds for every compiler/OS/configuration we're supposed to support.

certainly make it so that at least the Windows compiler treats these warnings as errors.

While I agree warnings should be fixed whenever possible, this seems counterproductive. It will simply cause libtiff to break all the time.

Olivier