2016.11.19 02:29 "Re: [Tiff] Visual Studio Warnings", by Aaron Boxer

By the way, I compiled that latest tifflib under linux 64 bit, gcc 5.4, and there are a number of warnings about "format %llu expects long long unsigned int but argument 4 has type toff_t (aka long unsigned int) "

For example:

"Failed to read directory at offset " TIFF_UINT64_FORMAT,nextdiroff);

tiff_dirread.c

On Fri, Nov 18, 2016 at 10:37 AM, Aaron Boxer <boxerab@gmail.com> wrote:

> Okey, dokey, the warnings are reduced. Thanks!

> Aaron
>

> On Thu, Nov 17, 2016 at 11:19 PM, Aaron Boxer <boxerab@gmail.com> wrote:

Thanks.

I've been getting my libtiff from this unofficial github mirror:

https://github.com/vadz/libtiff

Will have to wait to test until this repo gets updated with your latest check-ins.

On Thu, Nov 17, 2016 at 9:58 PM, Bob Friesenhahn < bfriesen@simple.dallas.tx.us> wrote:

Please check again and verify that the warnings are reduced.

The warnings regarding 'thandle_t' are a known issue. I suspect that using 'tif_unix.c' rather than 'tif_win32.c' is more reliable into the future under Windows (not knowing when 64-bit Windows will use handle values beyond 32-bits) until the handle size problem is fixed.

Anyone with a useful libtiff test suite should be running it this week

>>>>> that

it will no longer be pending as of Saturday the 19th.

Bob

On Wed, 16 Nov 2016, Aaron Boxer wrote:

>>> FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from 'int' to 'thandle_t' of greater size \libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation from 'thandle_t' to 'int' \libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation from 'thandle_t' to 'int' \libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored: 'snprintf'.

\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. \libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. \libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. \libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

>>>> --

Bob Friesenhahn

>>> bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/u
>>> sers/bfriesen/

GraphicsMagick Maintainer, http://www.GraphicsMagick.org/

>>> sers/bfriesen/

GraphicsMagick Maintainer, http://www.GraphicsMagick.org/