Thread

2013.05.01 13:57 "[Tiff] libtiff-4.0.3 bug report", by David Binderman

Hello there,

I just ran the static analyser "cppcheck" over the source code
libtiff-4.0.3. It said of

[iptcutil.c:224]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:238]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:241]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:256]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:266]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:281]: (warning) Storing getc() return value in char variable and then comparing with EOF

[iptcutil.c:295]: (warning) Storing getc() return value in char variable and then comparing with EOF

The return value from getc() must be stored into an int, before comparing with EOF.

Regards

David Binderman