2013.05.01 14:32 "Re: [Tiff] libtiff-4.0.3 bug report", by Bob Friesenhahn

On Wed, 1 May 2013, David Binderman wrote:

> Hello there,
>
> I just ran the static analyser "cppcheck" over the source code
> of libtiff-4.0.3. It said
>

> [iptcutil.c:224]: (warning) Storing getc() return value in char variable and then comparing with EOF

I opened the source file to take a look at this issue and immediately see the problem but then I see perhaps ten more types of problems that "cppcheck" did not warn about and are equally (and sometimes perhaps more) evil.

This is contributed old source code to serve as a useful example of parsing a format which was deprecated over 12 years ago (but is still in active use).

What would you like us to do?

Bob
--
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/