LibTiff Mailing List
TIFF and LibTiff Mailing List Archive
June 2010
Previous Thread
Next Thread
Previous by Thread
Next by Thread
Previous by Date
Next by Date
Contact
The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems
Thread
2010.06.28 13:25 "Re: [PATCH] Build tif_win32.c on Windows except on Cygwin", by Edward Lam
Seeing that there has been no movement on this in a week, Adam could you
submit this patch into the libtiff bug database? Just don't want this to
get lost.
Thanks,
-Edward
Adam Goode wrote:
> On 06/18/2010 02:21 PM, Bob Friesenhahn wrote:
>> On Fri, 18 Jun 2010, Adam Goode wrote:
>>>> That would be a nice patch.
>>> Here's a patch, can someone apply it?
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 954a0c5..2d8743b 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -147,6 +147,18 @@ AC_TYPE_SIZE_T
>>> AC_HEADER_TIME
>>> AC_STRUCT_TM
>>>
>>> +dnl Check for Win32 IO: make sure we have windows.h but not cygwin
>>> +case "${host_os}" in
>>> + cygwin*)
>>> + win32_io_ok=no
>> This bit seems wrong in the case where Cygwin is used to build a native
>> Windows (MinGW) application. It is also wrong for a MinGW
>> cross-compiler. The target OS should be what matters.
>>
>
> Also, there is another spot, just above in configure.ac that should be
> target_os, yes?
>
> dnl We don't need to add math library to all targets
> case "${host_os}" in
> cygwin* | mingw32* | beos* | darwin*)
> ;;
> *)
> AC_CHECK_LIB(m,sin,,,)
> ;;
> esac
>
>
>
> Adam
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Tiff mailing list: Tiff@lists.maptools.org
> http://lists.maptools.org/mailman/listinfo/tiff
> http://www.remotesensing.org/libtiff/