AWARE [SYSTEMS] Imaging expertise for the Delphi developer
AWare Systems, Imaging expertise for the Delphi developer, Home TIFF and LibTiff Mailing List Archive

LibTiff Mailing List

TIFF and LibTiff Mailing List Archive
July 2017

Previous Thread
Next Thread

Previous by Thread
Next by Thread

Previous by Date
Next by Date

Contact

The TIFF Mailing List Homepage
This list is run by Frank Warmerdam
Archive maintained by AWare Systems



Valid HTML 4.01!



Thread

2017.07.04 11:04 "A bug in libtiff error/warning handling", by Paavo Helde
2017.07.04 11:30 "Re: A bug in libtiff error/warning handling", by Even Rouault
2017.07.04 12:20 "Re: A bug in libtiff error/warning handling", by <rleigh@codelibre.net>
2017.07.04 12:55 "Re: A bug in libtiff error/warning handling", by Even Rouault
2017.07.04 12:30 "Re: A bug in libtiff error/warning handling", by Paavo Helde
2017.07.04 18:38 "Re: A bug in libtiff error/warning handling", by Bob Friesenhahn
2017.07.04 19:31 "Re: A bug in libtiff error/warning handling", by Paavo Helde
2017.07.05 12:12 "Re: A bug in libtiff error/warning handling", by Edward Lam
2017.07.05 12:40 "Re: A bug in libtiff error/warning handling", by Olivier Paquet
2017.07.05 13:41 "Re: A bug in libtiff error/warning handling", by Bob Friesenhahn
2017.07.05 13:57 "Re: A bug in libtiff error/warning handling", by Paavo Helde
2017.07.05 15:02 "Re: A bug in libtiff error/warning handling", by Olivier Paquet
2017.07.05 18:51 "Re: A bug in libtiff error/warning handling", by Paavo Helde
2017.07.05 19:36 "Re: A bug in libtiff error/warning handling", by Olivier Paquet

2017.07.04 11:30 "Re: A bug in libtiff error/warning handling", by Even Rouault

On mardi 4 juillet 2017 14:04:35 CEST Paavo Helde wrote:
> Hi,
> 
> I would like to report what I think is a bug in libtiff error and
> warning handling. There are two error handlers which can be installed
> (via TIFFSetErrorHandler and TIFFSetErrorHandlerExt) and which are
> called with a va_list. However, if both handlers are installed they will
> both iterate through the same va_list without reinitialization which is
> not allowed (seems to crash randomly with gcc on Linux, for example). I
> believe it should be the task of libtiff to reinitialize va_list between
> the calls. Ditto for warnings.
> 
> A patch file is attached, hopefully in a usable format.

That's a good point, but I wonder why you would have both error handlers installed ? That 
isn't really expected.

I'm wondering if we shouldn't use the HandlerExt on priority over the Handler to avoid the 
warning/error to be reported twice ? What do other devs think ?

But if we want to keep the current behaviour of reporting twice, your patch looks indeed 
right.

Even


-- 
Spatialys - Geospatial professional services
http://www.spatialys.com