2022.12.06 19:37 "[Tiff] Code base reformatting", by Even
Rouault
Thread
2022.12.06 19:37 "[Tiff] Code base reformatting", by Even Rouault
Hi,
Following discussions started in https://gitlab.com/libtiff/libtiff/-/merge_requests/415, I've submitted a merge request in https://gitlab.com/libtiff/libtiff/-/merge_requests/431 implementing:
- code reformatting of all .h/.c files using a simple style in .clang-format (https://gitlab.com/rouault/libtiff/-/blob/reformat/.clang-format). The output looks nice/good enough to me. Not difficult given the horrible look of the tabulation vs space mess we have currently.
- automatic tooling for developers using a pre-commit (https://github.com/pre-commit/pre-commit) hook that runs clang-format (and automatically download it the first tiime) at commit time to reformat the code if needed. Instructions for developers to set that up are in https://gitlab.com/rouault/libtiff/-/blob/reformat/CONTRIBUTING.md .
- Note: this only affects people modifying libtiff and wanting to contribute changes, not people just building it.
Hoping for no strong opposition and religious discussions about code formatting preferences, I'll merge this soon.
Even
http://www.spatialys.com
My software is free, but my time generally not.